[tbb-bugs] #27443 [Applications/Tor Browser]: Update Firefox RBM config and build for Android
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Nov 8 19:36:24 UTC 2018
#27443: Update Firefox RBM config and build for Android
-------------------------------------------------+-------------------------
Reporter: sisbell | Owner: tbb-
| team
Type: defect | Status:
| needs_revision
Priority: Very High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-rbm, tbb-mobile, TBA-a2, | Actual Points:
TorBrowserTeam201811 |
Parent ID: #26693 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by sysrqb):
Replying to [comment:48 sisbell]:
> Yes, this is the error that shows up if we don't use 21 or 22 NDK. I
previously had a patch that could make it run on other versions but I
think it would be better to use a version of the NDK that doesn't require
a patch. I'm ok with either 21 or 22, I just chose 22 since I default to
the highest compile version is best, due to possible bug fixes.
Replying to [comment:49 sisbell]:
> Changes (android-1108)
>
> * Changed android-version to 21 since sysrqb says this is the current
default. Documented reason for needing to use this version(s).
sisbell, can you post the patch needed for successfully building against
android-9? In our current code the default is android-9 for non-x86 CPU
targets, it is 21 for ['aarch64', 'x86_64', 'mips64'] cpu targets.
In August Mozilla bumped their versions:
https://hg.mozilla.org/mozilla-central/rev/2b2bd723ebc8
and now their default is [https://hg.mozilla.org/mozilla-
central/annotate/c291143e24019097d087f9307e59b49facaf90cb/build/moz.configure
/android-ndk.configure#l23 android 16].
I prefer not making drastic changes like this (jumping from android-9 to
android-22). Mozilla are very conservative about when they make these
changes with good reason. For changes like this, i wish we had a working
test suite. If we use this, then we need a lot of testing over the week
before we release the next alpha version.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27443#comment:50>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tbb-bugs
mailing list