[tbb-bugs] #28260 [Applications/Tor Browser]: Tor nightly builds are broken on Linux with Rust enabled (since 10/31)

[Tor Bug Tracker & Wiki]

#28260: Tor nightly builds are broken on Linux with Rust enabled (since 10/31)
--------------------------------------------+------------------------------
 Reporter:  gk                              |          Owner:  tbb-team
     Type:  defect                          |         Status:  needs_review
 Priority:  High                            |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201811R  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------------
Changes (by boklm):

 * keywords:  tbb-rbm, TorBrowserTeam201811 => tbb-rbm,
               TorBrowserTeam201811R
 * status:  new => needs_review


Comment:

 > <+GeKo> boklm: in other news i think the broken rust compliation is due
 to us creating $distdir only for macOS by |mkdir -p $distdir/helper|
 > <+GeKo> starting with the canonicalization rust got picky about exising
 dirs for the prefix it seems
 > <+GeKo> (i was wondering why i did not see the problem during my bisect
 thing for #26475)
 > <+GeKo> boklm: so, doing a |mkdir -p $distdir| right at the beginning
 (and just a |mkdir $distdir/helper| for macOS later on)
 > <+GeKo> should be all we need
 > <+GeKo> and i think we should go with 1.30.0 while we are at it
 > <+GeKo> feel free to test that and add it to your branch in case it
 helps

 Adding the `mkdir -p $distdir/helper` is indeed fixing the issue issue
 building 1.30.0.

 In branch `bug_28260_v3` there is a patch updating Rust to 1.30.0, only
 for Tor:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_28260_v3&id=8fc28dd994888b620d8e2ae334e2466e043dead1

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28260#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online