[tbb-bugs] #26204 [Applications/Tor Browser]: Bundle d3dcompiler_47.dll for Tor Browser 8

[Tor Bug Tracker & Wiki]

#26204: Bundle d3dcompiler_47.dll for Tor Browser 8
--------------------------------------------+------------------------------
 Reporter:  gk                              |          Owner:  tbb-team
     Type:  defect                          |         Status:
                                            |  needs_revision
 Priority:  Very High                       |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201805  |  Actual Points:
Parent ID:  #26203                          |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------------

Comment (by sukhbir):

 Replying to [comment:3 boklm]:

 Thanks for the review!

 > The patch looks good to me, although I did not try to build the firefox
 part.
 >
 > However I think we are missing the part where we copy the
 `d3dcompiler_47.dll` file to the bundle (I think in `$distdir/Browser`).

 I added it by setting `fxcdir` and copying the `dll`. Is that fine or can
 we do better?

 > And a minor thing: you can indent the `make` lines in the `IF` to make
 that easier to read. Or maybe it can be simplified like this:
 > {{{
 > diff --git a/projects/fxc2/build b/projects/fxc2/build
 > index 6ff3808..1b48326 100644
 > --- a/projects/fxc2/build
 > +++ b/projects/fxc2/build
 > @@ -8,11 +8,7 @@ mkdir -p /var/tmp/build
 >  tar -C /var/tmp/build -xf [% project %]-[% c("version") %].tar.gz
 >  cd /var/tmp/build/[% project %]-[% c("version") %]
 >
 > -[% IF c("arch") == "i686" -%]
 > -make x86
 > -[% ELSE -%]
 > -make x64
 > -[% END -%]
 > +make [% IF c("var/windows-i686") %]x86[% ELSE %]x64[% END %]
 >
 >  mkdir -p /var/tmp/dist/fxc2/bin/
 >  cp fxc2.exe /var/tmp/dist/fxc2/bin/
 > }}}

 Updated; to maintain consistency, I went with adding the indent instead of
 doing it one line.

 (Same branch.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26204#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online