[tbb-bugs] #26127 [Applications/Tor Browser]: Make sure Torbutton and Tor Launcher are not treated as legacy extensions

[Tor Bug Tracker & Wiki]

#26127: Make sure Torbutton and Tor Launcher are not treated as legacy extensions
---------------------------------------------+-----------------------------
 Reporter:  gk                               |          Owner:  tbb-team
     Type:  defect                           |         Status:
                                             |  needs_review
 Priority:  Very High                        |      Milestone:
Component:  Applications/Tor Browser         |        Version:
 Severity:  Normal                           |     Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201805R  |  Actual Points:
Parent ID:                                   |         Points:
 Reviewer:                                   |        Sponsor:
---------------------------------------------+-----------------------------

Comment (by arthuredelstein):

 Replying to [comment:3 gk]:
 > A fix for this bug is up in my `bug_26127`
 (https://gitweb.torproject.org/user/gk/tor-
 browser.git/commit/?h=bug_26127&id=4eaeeb9b41e6509b97e3dd216a2e92572fc9b37b).
 Please review.

 I noticed it's possible to leave "extensions.legacy.enabled" false and you
 can still whitelist torbutton and tor-launcher. This might be a little
 safer by still providing a warning for any other legacy extensions
 installed.

 But the other two lines of code look fine.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26127#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online