[tbb-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Mar 19 18:52:45 UTC 2018
#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
-------------------------------------------------+-------------------------
Reporter: gk | Owner: tbb-
| team
Type: task | Status:
| needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-rbm, TorBrowserTeam201803R, | Actual Points:
boklm201803 |
Parent ID: #12968 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by cypherpunks):
Replying to [comment:54 gk]:
> Replying to [comment:53 cypherpunks]:
> > Replying to [comment:52 gk]:
> > > Replying to [comment:49 cypherpunks]:
> > > > Replying to [comment:48 boklm]:
> > > > You can easily back out the above mentioned 3-line patch and test
the latest binutils. Switching to ucrtbase.dll from your home-made
msvcrt.dll hack looks better, though.
> > >
> > > Yes, but the ucrtbase approach is not ready yet, alas. It's not
sufficiently mature yet for getting used for our Windows builds.
> > It has been run on TC for quite some time, and Tom didn't file any
issue with it. So, could you explain what is missing?
>
> Beacuse he is not using ucrtbase yet but plain msvcrt (you are using the
former with `--with-default-msvcrt=ucrtbase`).
Oh, he was going to solve some issues by using it, but it didn't happen,
heh.
> See: https://bugzilla.mozilla.org/show_bug.cgi?id=1390583#c51 for an
unresolved issue.
Weird. Does `--with-default-msvcrt=msvcr100` work for you?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16472#comment:55>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tbb-bugs
mailing list