[tbb-bugs] #25420 [Applications/Tor Browser]: Update gcc to 6.4.0 (Windows)

[Tor Bug Tracker & Wiki]

#25420: Update gcc to 6.4.0 (Windows)
-------------------------------------------------+-------------------------
 Reporter:  boklm                                |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:  new
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201803,       |  Actual Points:
  boklm201803                                    |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by boklm):

 Thanks, this patch is indeed fixing the issue.

 The next build issue is:
 {{{
 /var/tmp/dist/mingw-w64/helpers/i686-w64-mingw32-g++ -std=gnu++11
 -mwindows -o NameTable.o -c -I/var/tmp/build/firefox-8ee6fdadea2a/obj-
 mingw/dist/stl_wrappers  -DNDEBUG
 =1 -DTRIMMED=1 -DGRAPHITE2_STATIC '-DPACKAGE_VERSION="moz"'
 '-DPACKAGE_BUGREPORT="http://bugzilla.mozilla.org/"' -DGRAPHITE2_NFILEFACE
 -DGRAPHITE2_NTRACING -DGRAPHITE2_N
 SEGCACHE '-DGRAPHITE2_CUSTOM_HEADER="MozGrMalloc.h"' -I/var/tmp/build
 /firefox-8ee6fdadea2a/gfx/graphite2/src -I/var/tmp/build/firefox-
 8ee6fdadea2a/obj-mingw/gfx/graphite
 2/src  -I/var/tmp/build/firefox-8ee6fdadea2a/obj-mingw/dist/include
 -I/var/tmp/build/firefox-8ee6fdadea2a/obj-mingw/dist/include/nspr
 -I/var/tmp/build/firefox-8ee6fdade
 a2a/obj-mingw/dist/include/nss         -DMOZILLA_CLIENT -include
 /var/tmp/build/firefox-8ee6fdadea2a/obj-mingw/mozilla-config.h -MD -MP -MF
 .deps/NameTable.o.pp  -Wall -
 Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual
 -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-
 strings -Wno-invalid-offseto
 f -Wc++14-compat -Wno-error=maybe-uninitialized -Wno-error=deprecated-
 declarations -Wno-error=array-bounds -Wno-format -fno-lifetime-dse -fno-
 exceptions -fno-strict-alia
 sing -mms-bitfields -mstackrealign -fno-keep-inline-dllexport -fno-rtti
 -fno-exceptions -fno-math-errno -pipe  -g -O -fno-omit-frame-pointer
 /var/tmp/build/firefox-8e
 e6fdadea2a/gfx/graphite2/src/NameTable.cpp
 libdom_messagechannel.a.desc
 rm -f libdom_messagechannel.a
 /var/tmp/build/firefox-8ee6fdadea2a/obj-mingw/_virtualenv/bin/python
 /var/tmp/build/firefox-8ee6fdadea2a/config/expandlibs_gen.py -o
 libdom_messagechannel.a.desc Unified
 _cpp_dom_messagechannel0.o
 In file included from /var/tmp/build/firefox-
 8ee6fdadea2a/gfx/graphite2/src/inc/Main.h:33:0,
                  from /var/tmp/build/firefox-
 8ee6fdadea2a/gfx/graphite2/src/NameTable.cpp:27:
 /var/tmp/build/firefox-8ee6fdadea2a/gfx/graphite2/src/MozGrMalloc.h:16:16:
 error: 'std::moz_xcalloc' has not been declared
  #define calloc moz_xcalloc
                 ^
 /var/tmp/build/firefox-8ee6fdadea2a/gfx/graphite2/src/MozGrMalloc.h:15:16:
 error: 'std::moz_xmalloc' has not been declared
  #define malloc moz_xmalloc
                 ^
 /var/tmp/build/firefox-8ee6fdadea2a/gfx/graphite2/src/MozGrMalloc.h:17:17:
 error: 'std::moz_xrealloc' has not been declared
  #define realloc moz_xrealloc
                  ^
 /var/tmp/build/firefox-8ee6fdadea2a/config/rules.mk:951: recipe for target
 'NameTable.o' failed
 make[5]: *** [NameTable.o] Error 1
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25420#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online