[tbb-bugs] #26985 [Applications/Tor Launcher]: help button icons missing

[Tor Bug Tracker & Wiki]

#26985: help button icons missing
--------------------------------------------+--------------------------
 Reporter:  mcs                             |          Owner:  mcs
     Type:  defect                          |         Status:  assigned
 Priority:  Very High                       |      Milestone:
Component:  Applications/Tor Launcher       |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201807  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+--------------------------

Comment (by mcs):

 The image from ESR52 is chrome://browser/skin/menuPanel-help.png (in the
 source tree, the path is browser/themes/linux/menuPanel-help.png on Linux
 and similar images exist for Windows and macOS). The image contains
 multiple renderings to cover "on click" and "on hover" states which we use
 in Tor Launcher.

 The replacement image that is in ESR60 is
 chrome://global/skin/icons/help.svg (in the source tree there is just one
 image at toolkit/themes/shared/icons/help.svg). Since this image does not
 have "on click" and "on hover" renderings, we will need to decide what we
 want to do in those cases. In the hamburger menu where Firefox uses this
 new image, the background color of the entire menu row is changed upon
 hover but that is not appropriate in Tor Launcher since we use the help
 icons for standalone buttons.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26985#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online