[tbb-bugs] #9145 [Applications/Tor Browser]: Tor Browser for Windows is borked with hardware acceleration enabled (because of gcc?)

[Tor Bug Tracker & Wiki]

#9145: Tor Browser for Windows is borked with hardware acceleration enabled
(because of gcc?)
-------------------------------------------------+-------------------------
 Reporter:  dope457                              |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-crash, fuck-mingw, ff60-esr,     |  Actual Points:
  TorBrowserTeam201807R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sukhbir):

 Replying to [comment:43 gk]:
 > Would it be enough to just have
 `CXXFLAGS="-DWIDL_EXPLICIT_AGGREGATE_RETURNS"` instead of
 `CXXFLAGS="$CXXFLAGS -DWIDL_EXPLICIT_AGGREGATE_RETURNS"`? I wonder if we
 should do an `export CXXFLAGS` instead of just a `CXXFLAGS` as Mozilla is
 doing it in the cross-compile macOS mozconfig, to pass down the flags to
 the various parts of the build system.

 OK I updated it to `export CXXFLAGS` instead and also rebased it on the
 respective HEAD commits.

 Tor Browser build:

 https://github.com/azadi/tor-browser-build-1/tree/bug-9145-rev1

 Tor Browser (should this have been a `fixup` commit perhaps?):

 https://github.com/azadi/gecko-dev/tree/bug-9145

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9145#comment:44>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online