[tbb-bugs] #26477 [Applications/Tor Browser]: Meek is broken in ESR60-based Tor Browser

[Tor Bug Tracker & Wiki]

#26477: Meek is broken in ESR60-based Tor Browser
--------------------------------------------+--------------------------
 Reporter:  gk                              |          Owner:  tbb-team
     Type:  defect                          |         Status:  new
 Priority:  Very High                       |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201807  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+--------------------------

Comment (by dcf):

 I tried it on 8.0a9. I didn't get the "already running" errors mentioned
 in the ticket description (may be #12774?). What I got instead was a big
 empty browser window and a progress bar stuck at 0%. I opened the
 JavaScript console in the browser window with Ctrl+Shift+J and got this:
 [[Image(tb-8.0a9-meek-js-console.png)]]
 ||NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012
 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import] ||main.js:43 ||
 ||While creating services from category 'profile-after-change', could not
 create service for entry 'MeekHTTPHelper', contract ID !'@bamsoftware.com
 /meek-http-helper;1' || ||
 ||Warning: unrecognized command line flag -invisible
 ||nsBrowserContentHandler.js:837 ||
 ||dch_handle jar:file:///home/david/tor-browser-linux64-8.0a9_en-US/tor-
 browser_en-
 US/Browser/browser/omni.ja!/components/nsBrowserContentHandler.js:837:9 ||
 ||
 ||NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111
 (NS_ERROR_NOT_AVAILABLE) [nsIWebNavigation.loadURIWithOptions] ||browser-
 child.js:359 ||

 It looks like the two errors are around `nsIXPCComponents_Utils.import`
 and `nsIWebNavigation.loadURIWithOptions`. The error about `-invisible`
 seems to be from a changed command-line interface (meek-client-torbrowser
 passes `-invisible` to firefox).

 Somehow I seem to remember someone telling me that one of the imports had
 changed in ESR60. But now I can't find any record of it. Anyway, I think
 it was about needing to change the current
 {{{
 Components.utils.import("resource://gre/modules/devtools/Console.jsm");
 }}}
 to
 {{{
 Components.utils.import("resource://gre/modules/Console.jsm");
 }}}
 as is now documented at https://developer.mozilla.org/en-
 US/docs/Tools/Browser_Console#Console.jsm. That may explain the first
 import failure.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26477#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online