[tbb-bugs] #18691 [Applications/Tor Browser]: Switch rbm VMs for Windows to those used for our macOS cross-builds

[Tor Bug Tracker & Wiki]

#18691: Switch rbm VMs for Windows to those used for our macOS cross-builds
-------------------------------------------+--------------------------
 Reporter:  gk                             |          Owner:  tbb-team
     Type:  enhancement                    |         Status:  new
 Priority:  Medium                         |      Milestone:
Component:  Applications/Tor Browser       |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201801  |  Actual Points:
Parent ID:                                 |         Points:
 Reviewer:                                 |        Sponsor:
-------------------------------------------+--------------------------

Comment (by boklm):

 The first issue when switching to `jessie` for the Windows builds is a
 build error in binutils:
 {{{
 In file included from as.h:95:0,
                  from subsegs.c:25:
 subsegs.c: In function 'subseg_change':
 ../bfd/bfd.h:304:75: error: right-hand operand of comma expression has no
 effect [-Werror=unused-value]
  #define bfd_set_section_userdata(bfd, ptr, val) (((ptr)->userdata =
 (val)),TRUE)
 ^
 subsegs.c:70:7: note: in expansion of macro 'bfd_set_section_userdata'
        bfd_set_section_userdata (stdoutput, seg, seginfo);
        ^
 subsegs.c: In function 'subseg_get':
 ../bfd/bfd.h:304:75: error: right-hand operand of comma expression has no
 effect [-Werror=unused-value]
  #define bfd_set_section_userdata(bfd, ptr, val) (((ptr)->userdata =
 (val)),TRUE)
 ^
 subsegs.c:172:7: note: in expansion of macro 'bfd_set_section_userdata'
        bfd_set_section_userdata (stdoutput, secptr, seginfo);
        ^
 In file included from as.h:95:0,
                  from write.c:25:
 write.c: In function 'record_alignment':
 ../bfd/bfd.h:303:83: error: right-hand operand of comma expression has no
 effect [-Werror=unused-value]
  #define bfd_set_section_alignment(bfd, ptr, val) (((ptr)->alignment_power
 = (val)),TRUE)
 ^
 write.c:366:5: note: in expansion of macro 'bfd_set_section_alignment'
      bfd_set_section_alignment (stdoutput, seg, align);
      ^
 cc1: all warnings being treated as errors
 }}}

 This issue is fixed by taking commit
 27b829ee701e29804216b3803fbaeb629be27491 from binutils:
 https://sourceware.org/git/gitweb.cgi?p=binutils-
 gdb.git;a=commitdiff;h=27b829ee701e29804216b3803fbaeb629be27491

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18691#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online