[tbb-bugs] #25364 [Applications/Tor Browser]: TBA - Create a TOR_BROWSER_VERSION AppConstant
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Feb 27 01:17:26 UTC 2018
#25364: TBA - Create a TOR_BROWSER_VERSION AppConstant
------------------------------------------+------------------------
Reporter: sysrqb | Owner: tbb-team
Type: enhancement | Status: new
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Keywords: tbb-mobile
Actual Points: | Parent ID: #5709
Points: | Reviewer:
Sponsor: |
------------------------------------------+------------------------
The mobile/android/ code doesn't use a preprocessor like the C++ and
Javascript code. Instead, there is a class AppConstants containing
constant values (and getters) that are set at build time. We will need
this for handling when we should do something Tor Browser-specific.
Currently Orfox comments large blocks of code, however this isn't easily
maintainable and it's not clean, especially if we are (closely) following
m-c. If we have a build-time constant, then we can accomplish similar
functionality as the mozbuild preprocessor conditional statements.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25364>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tbb-bugs
mailing list