[tbb-bugs] #25331 [Applications/Tor Browser]: Test from #18912 failing

[Tor Bug Tracker & Wiki]

#25331: Test from #18912 failing
--------------------------------------+-----------------------------------
 Reporter:  arthuredelstein           |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_information
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:                            |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+-----------------------------------

Comment (by arthuredelstein):

 I built `tor-browser.git` and confirmed in about:config that
 `security.nocertdb` is set to true.

 Then I ran the same 3 tests as before:
 {{{
 ./mach mochitest
 toolkit/mozapps/update/tests/chrome/test_0790_check_certPinning_noUpdate.xul
 }}}
 gave
 {{{
 56 INFO TEST-UNEXPECTED-FAIL |
 toolkit/mozapps/update/tests/chrome/test_0790_check_certPinning_noUpdate.xul
 | Checking update.errorCode == MOZILLA_PKIX_ERROR_KEY_PINNING_FAILURE -
 got 2153390067, expected 2153398272
 }}}
 Then
 {{{
 ./mach mochitest --setpref=security.nocertdb=false
 toolkit/mozapps/update/tests/chrome/test_0790_check_certPinning_noUpdate.xul
 }}}
 resulted in all tests passing. Finally,
 {{{
 ./mach mochitest --setpref=security.nocertdb=true
 toolkit/mozapps/update/tests/chrome/test_0790_check_certPinning_noUpdate.xul
 }}}
 gave the result
 {{{
 56 INFO TEST-UNEXPECTED-FAIL |
 toolkit/mozapps/update/tests/chrome/test_0790_check_certPinning_noUpdate.xul
 | Checking update.errorCode == MOZILLA_PKIX_ERROR_KEY_PINNING_FAILURE -
 got 2153390067, expected 2153398272
 }}}
 So to analyze: my observation in the description `tor-
 browser-52.6.0esr-8.0-2` was irrelevant because I had left
 `security.nocertdb=true` (Both branches give the same unexpected error
 code of `2153390067`, but that's not very relevant.). If we look at
 `security.nocertdb=false` only, then I see that the test passes for `tor-
 browser-52.6.0esr-8.0-2` but it fails on top of `mozilla-central` with a
 different unexpected error code of `2153394164`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25331#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online