[tbb-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--------------------------------------+--------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  task                      |         Status:  new
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-rbm, boklm201802      |  Actual Points:
Parent ID:  #12968                    |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by gk):

 Replying to [comment:14 boklm]:
 > In branch `bug_16472_v2` I added a commit updating binutils to 2.30:
 > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_16472_v2&id=fd2706c19dad44730ef10f8d868ac965d84a65b7
 >
 > I also added a test commit adding two `tor-browser.git` patches fixing
 the build, but I am not sure that they are correct:
 > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_16472_v2&id=868c0384fa306f51f5be5e16a32b6ef063ade2a9
 >
 > However, after updating gcc to 6.4.0, it seems those two patches are not
 needed anymore (and make the build fail). So I think we should update both
 binutils and gcc at the same time.

 Agreed, bumping both at the same time sounds like a good idea, especially
 if that means we don't need those additional patches.

 Have you checked about the deterministic output of the Windows bundles
 after the switch to the newer  binutils version? That's has been the main
 reason for why an update did not happen earlier (see: comment:1).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16472#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online