[tbb-bugs] #19910 [Applications/Tor Browser]: Rip out optimistic data socks handshake variant (#3875)

[Tor Bug Tracker & Wiki]

#19910: Rip out optimistic data socks handshake variant (#3875)
--------------------------------------------+--------------------------
 Reporter:  cypherpunks                     |          Owner:  tbb-team
     Type:  defect                          |         Status:  closed
 Priority:  Medium                          |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:  fixed
 Keywords:  ux-team, TorBrowserTeam201802R  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+--------------------------
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 This is basically reverting 6d594cc227f153364b91e8310d59a07d7d6ce5f6,
 right? If so, just doing a `git revert
 6d594cc227f153364b91e8310d59a07d7d6ce5f6` is slightly better as the next
 rebase would then automatically remove the optimistic SOCKS handshake
 code. I try to remember doing that manually. :)

 Applied to `tor-browser-52.6.0esr-8.0-2` (commit
 67fa1e520d8cfc420f5bdee4b53b8310df18a977).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19910#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online