[tbb-bugs] #28754 [Applications/Tor Browser]: make testbuild-android-armv7 stalls during sha256sum step
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Dec 6 13:15:15 UTC 2018
#28754: make testbuild-android-armv7 stalls during sha256sum step
------------------------------------------+----------------------
Reporter: gk | Owner: tbb-team
Type: defect | Status: new
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Keywords: tbb-rbm
Actual Points: | Parent ID:
Points: | Reviewer:
Sponsor: |
------------------------------------------+----------------------
Suppose you don't have a testbuild directory containing any already built
bundles. Now, start a build with `make testbuild-android-armv7` to get an
.apk. The result is a stalled build in the release project.
The reason for that is that
{{{
sha256sum $(ls -1 *.exe *.tar.xz *.dmg *.mar *.zip *.tar.gz | grep -v
'\.incremental\.mar$' | sort) > sha256sums-unsigned-build.txt
}}}
evaluates to
{{{
sha256sum > sha256sums-unsigned-build.txt
}}}
which waits for input. We have not been hitting that so far as both in the
alpha and the nightly case other bundles in the directory are available.
And for the mobile case #25164 is about to fix this as well. However, we
might want to be a bit more conservative and only execute `sha256sum` if
we actually have an argument to pass. Otherwise this can lead to
surprising results (like in this case).
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28754>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tbb-bugs
mailing list