[tbb-bugs] #13373 [Applications/Tor Browser]: Get rid of LD_LIBRARY_PATH and use a relative RPATH/RUNPATH in Linux bundles

[Tor Bug Tracker & Wiki]

#13373: Get rid of LD_LIBRARY_PATH and use a relative RPATH/RUNPATH in Linux
bundles
--------------------------------------+------------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  enhancement               |         Status:  needs_review
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-rbm                   |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+------------------------------
Changes (by sukhbir):

 * status:  new => needs_review


Comment:

 For review (will need!):

 https://github.com/azadi/tor-browser-build-1/tree/bug-13373

 This still has an issue but I thought I should submit the current state
 for review. The issue is that for selfrando and as per #22242, we do this
 in `firefox/build`:

 {{{
 219       [% IF c("var/selfrando") -%]
 220         # remove RUNPATH added by selfrando (see #22242)
 221         chrpath -d $LIB
 222       [% END -%]
 }}}

 So this removes the `RUNPATH` for `firefox.real` even if we set it during
 the build (as in the above branch). So as per the current branch and if we
 remove the selfrando line, the `RUNPATH` looks like:

 {{{
  0x000000000000001d (RUNPATH)            Library runpath:
 [/var/tmp/dist/selfrando/out/x86_64/bin:$ORIGIN/TorBrowser/Tor]
 }}}

 which is we want except we don't want it for selfrando? So how should we
 handle this? Should we set the `RUNPATH` for Firefox, then remove the one
 for selfrando selectively? Or should we not bother to compile Firefox with
 the `RUNPATH` and then later change it manually using `chrpath`? I am not
 sure what is the preferred approach.

 Other things that remain: updating the tests in `tor-browser-bundle-
 testsuite.git`.

 PS: I also fixed #24465 in this commit since it was (somewhat) related and
 is a one-line change.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13373#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online