[tbb-bugs] #27221 [Applications/Tor Browser]: Tor Browser 8.0a10 wants to update to 8.0a10

[Tor Bug Tracker & Wiki]

#27221: Tor Browser 8.0a10 wants to update to 8.0a10
--------------------------------------------+--------------------------
 Reporter:  boklm                           |          Owner:  tbb-team
     Type:  defect                          |         Status:  new
 Priority:  Very High                       |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201808  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+--------------------------

Comment (by boklm):

 Replying to [comment:13 mcs]:
 > As far as we can tell, that `InvalidateCache()` method is only called in
 response to a `startupcache-invalidate` observer notification. But we
 don't see a place where that is generated after an update or if one were
 to install new bits over the top of an existing browser.

 In `startup()` in `toolkit/mozapps/extensions/internal/XPIProvider.jsm`,
 it seems that a `startupcache-invalidate` notification is sent if
 `flushCaches` is true:
 {{{
      let flushCaches = this.checkForChanges(aAppChanged, aOldAppVersion,
                                              aOldPlatformVersion);
 }}}

 And it seems that it is looking at the `AppVersion` and `PlatformVersion`
 to decide that.

 I see that the prefs `extensions.lastAppVersion` and
 `extensions.lastPlatformVersion` are both set to `60.1.0`, which didn't
 change between `8.0a9` and `8.0a10`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27221#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online