[tbb-bugs] #26520 [Applications/Tor Browser]: NoScript is broken with TOR_SKIP_LAUNCH=1 in ESR 60-based Tor Browser

[Tor Bug Tracker & Wiki]

#26520: NoScript is broken with TOR_SKIP_LAUNCH=1 in ESR 60-based Tor Browser
--------------------------------------------+------------------------------
 Reporter:  gk                              |          Owner:  tbb-team
     Type:  defect                          |         Status:
                                            |  needs_revision
 Priority:  Very High                       |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201808  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------------

Comment (by rustybird):

 @arthuredelstein: As an experiment, I added a patch (debug-retry.diff) on
 top of your second patch. It reverts to the previous approach of
 immediately calling `sendMessage()` instead of waiting for a message from
 NoScript first, and it also retries on failure. Weirdly, after logging
 about ten failures and then a success to the Browser Console, JavaScript
 is still disabled! (On a fresh TB installation.) Maybe there's a second
 race condition somewhere, e.g. NoScript ignoring a message delivered
 successfully but very early?

 BTW should this ticket have the AffectsTails keyword?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26520#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online