[tbb-bugs] #24796 [Applications/Tor Browser]: Review all requested and required Android permissions

[Tor Bug Tracker & Wiki]

#24796: Review all requested and required Android permissions
----------------------------------------------+----------------------------
 Reporter:  sysrqb                            |          Owner:  tbb-team
     Type:  task                              |         Status:
                                              |  needs_revision
 Priority:  High                              |      Milestone:
Component:  Applications/Tor Browser          |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201808  |  Actual Points:
Parent ID:  #26531                            |         Points:
 Reviewer:                                    |        Sponsor:
----------------------------------------------+----------------------------
Changes (by gk):

 * keywords:  tbb-mobile, TorBrowserTeam201808R => tbb-mobile,
     TorBrowserTeam201808
 * status:  needs_review => needs_revision


Comment:

 Could you please to the following things

 1) If the `#ifdef`s don't work let's not include them as this is
 confusing. Rather we could fall back to the `<!--#ifdef MOZ_WEBRTC-->`
 style indicating where `#ifdef`s would be available if we had them

 2) Could you put
 {{{
 +    <!--
      <uses-permission android:name="android.permission.CAMERA" />
      <uses-feature android:name="android.hardware.camera"
 android:required="false"/>
      <uses-feature android:name="android.hardware.camera.autofocus"
 android:required="false"/>
 +    -->
 }}}
 into the WebRTC block so that it is easier to see that they belong
 together (assuming `FennecManifest_permissions.xml.in` has that part
 right).

 3) The first part of the patch is
 {{{
 #ifdef MOZ_ANDROID_NETWORK_STATE
 +    <!--
      <uses-permission
 android:name="android.permission.CHANGE_WIFI_STATE"/>
      <uses-permission
 android:name="android.permission.ACCESS_WIFI_STATE"/>
      <uses-permission
 android:name="android.permission.ACCESS_COARSE_LOCATION"/>
      <uses-permission
 android:name="android.permission.ACCESS_FINE_LOCATION"/>
      <uses-permission
 android:name="android.permission.ACCESS_NETWORK_STATE"/>
 +    -->
  #endif
 }}}
 but if you compare that to the respective part in
 `FennecManifest_permissions.xml.in`
 {{{
 #ifdef MOZ_ANDROID_NETWORK_STATE
     <!-- Android WIFI state -->
     <uses-permission android:name="android.permission.CHANGE_WIFI_STATE"/>
     <uses-permission android:name="android.permission.ACCESS_WIFI_STATE"/>
 #endif

 #ifdef MOZ_ANDROID_LOCATION
     <uses-permission
 android:name="android.permission.ACCESS_COARSE_LOCATION"/>
     <uses-permission
 android:name="android.permission.ACCESS_FINE_LOCATION"/>
 #endif
     <uses-permission
 android:name="android.permission.ACCESS_NETWORK_STATE"/>
 }}}
 that's not aligned (`ACCESS_NETWORK_STATE` is treated differently).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24796#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online