[tbb-bugs] #24056 [Applications/Tor Browser]: UI locale is detectable by button width

[Tor Bug Tracker & Wiki]

#24056: UI locale is detectable by button width
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  tbb-fingerprinting,                  |  Actual Points:
  TorBrowserTeam201808                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by arthuredelstein):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:7 gk]:
 > Replying to [comment:6 arthuredelstein]:
 > > Here's the revised patch:
 > > https://github.com/arthuredelstein/tor-browser/commit/24056+1
 >
 > It seems we don't need to potentially adjust `aFile` in
 > {{{
 > nsresult nsContentUtils::FormatLocalizedString(
 >                                           PropertiesFile aFile,
 >                                           const char* aKey,
 >                                           const nsTArray<nsString>&
 aParamArray,
 >                                           nsAString& aResult)
 > }}}
 > as it does not get touched in it but rather gets passed on.

 You're right. I removed the inserted lines there.

 > I guess we are safe regarding `GetLocalizedEllipsis()`? At least I hope
 so, assuming the localization folks adhered to Mozilla's advice to use
 `\u2026` for it...

 Good point. I think it's safer to patch this. I have done so in this
 latest version:

 ​https://github.com/arthuredelstein/tor-browser/commit/24056+2

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24056#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online