[tbb-bugs] #26858 [Applications/Tor Browser]: TBA: Investigating patching AccountManager

[Tor Bug Tracker & Wiki]

#26858: TBA: Investigating patching AccountManager
--------------------------------------+--------------------------
 Reporter:  sysrqb                    |          Owner:  tbb-team
     Type:  defect                    |         Status:  new
 Priority:  Very High                 |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-mobile                |  Actual Points:
Parent ID:  #26531                    |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by sysrqb):

 Replying to [ticket:26858 sysrqb]:
 > Orfox previously patched some of the AccountManager and Sync code. Are
 these still needed?
 >
 > https://github.com/guardianproject/tor-
 browser/commit/45ba8e208975daebda7520ea0f111f475adba967

 1)  `mobile/android/base/java/org/mozilla/gecko/AccountsHelper.java`

   `AccountsHelper` is never used because we deleted the only instance in
 `BrowserApp` in `Bug 25741 - TBA: Neuter Firefox Accounts`.

 2) `ContactService.java`

   This was deleted in:
 {{{
 commit 9a8b60ffcae1d642096c9aaedfdd3cf37f87fe7f
 Author: Makoto Kato <m_kato at ga2.so-net.ne.jp>
 Date:   Mon Aug 8 15:40:19 2016 +0900

     Bug 1284283 - Remove MozContact API Android backend. r=sebastian

     MozReview-Commit-ID: GLhrA1cc1Rq

     --HG--
     extra : rebase_source : 73efab6d9468388a6ba0be489250d8dd3d185cd6
 }}}

 3) `Tabs.java`

   This still exists, and an instance of AccountManager is still retrieved
 here. We should clean this. I believe the goal here is preventing the
 caching of current tabs on disk (`queuePersistAllTabs()`).

 4)
 `mobile/android/base/java/org/mozilla/gecko/overlays/service/sharemethods/SendTab.java`

   We should clean this. It is initialized in `OverlayActionService.java`,
 it's a background service for handling sharing the current tab with
 another device (when FxA/sync are enabled).

 5)
 `mobile/android/services/src/main/java/org/mozilla/gecko/fxa/FirefoxAccounts.java`

   Already cleaned in FxA neutering

 6)
 `mobile/android/services/src/main/java/org/mozilla/gecko/fxa/activities/FxAccountStatusActivity.java`

   Needs cleaning.

 7)
 `mobile/android/services/src/main/java/org/mozilla/gecko/sync/setup/SyncAccounts.java`

   Deleted in:
 {{{
 commit 4978a3514277d4cc310ee6e15072d15abd1dfe2a
 Author: Nick Alexander <nalexander at mozilla.com>
 Date:   Mon Jan 18 17:02:56 2016 -0800

     Bug 1220906 - Part 6: Remove Old Sync configuration code. r=rnewman

     --HG--
     extra : commitid : 1NbJi3JriIB
     extra : rebase_source : 895092b10bf20b0425e266a1d340e22b81f8daee
 }}}

 8)
 `mobile/android/services/src/main/java/org/mozilla/gecko/sync/setup/activities/SetupSyncActivity.java`

   Deleted in:
 {{{
 commit 35d2682654031d011b46bb07344490686f748117
 Author: Nick Alexander <nalexander at mozilla.com>
 Date:   Tue Jan 19 11:31:31 2016 -0800

     Bug 1220906 - Part 5: Remove Old Sync setup and JPAKE code. r=rnewman

     --HG--
     extra : commitid : DrheDFD75zQ
     extra : rebase_source : 4249543a2df591bf042b93094a2f112fd8460805
 }}}


 > https://github.com/guardianproject/tor-
 browser/commit/b044089a93bd36ddb454ac11eecc72a2c295229c

 Already deleted in:
 {{{
 commit 99f346a73bde893c862bbb6504ff52f63b5b60e0
 Author: Amogh Pradeep <amoghbl1 at gmail.com>
 Date:   Fri Jul 17 13:27:07 2015 -0400

     Bug 25741 - TBA: Remove sync option from preferences

     We don't want this while the Sync subsystem is a proxy-bypass risk. We
     can drop this when the feature is patched.

     Signed-off-by: Amogh Pradeep <amoghbl1 at gmail.com>
 }}}

 But, we should delete in
 `mobile/android/app/src/main/res/xml/preferences_general_tablet.xml`, too.

 > https://github.com/guardianproject/tor-
 browser/commit/842618571bbe865657836447cbd50fffc027b582
 >

 This isn't needed because the firstrun page was changed so it used the
 `RestrictedWelcomePanel`, and TBA's onboarding/welcome will be custom-
 built.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26858#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online