[tbb-bugs] #22564 [Applications/Tor Browser]: Hide firefox sync

[Tor Bug Tracker & Wiki]

#22564: Hide firefox sync
-------------------------------------------------+-------------------------
 Reporter:  Dbryrtfbcbhgf                        |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-7.0-issues, tbb-regression,      |  Actual Points:
  TorBrowserTeam201709                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:  tbb-7.0-issues, tbb-regression, TorBrowserTeam201709R =>
     tbb-7.0-issues, tbb-regression, TorBrowserTeam201709
 * status:  needs_review => needs_revision


Comment:

 I tested it on a Linux system and it works for me, thanks. One thing to
 fix:
 {{{
 +      Services.prefs.removeObserver(PREF_SYNC_UI_HIDDEN, gSyncUI, false);
 }}}
 I don't think there is a `removeObserver()` that takes three arguments.

 Then you are adding observers in two more places (`preferences.js` and
 `CustomizableUI.jsm`) without removing them. I wonder whether that was
 intentionally. If so, shouldn't we remove them e.g. when the preferences
 pane is closed given that we are adding it when opening that very pane.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22564#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online