[tbb-bugs] #23724 [Applications/Tor Browser]: NoScript restartless update breaks Security Slider and its icon disappears

[Tor Bug Tracker & Wiki]

#23724: NoScript restartless update breaks Security Slider and its icon disappears
--------------------------------------+--------------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_revision
 Priority:  High                      |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Critical                  |     Resolution:
 Keywords:  noscript                  |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------------

Comment (by cypherpunks):

 > On subsequent restarts I get
 {{{
 noscript-tbb not found!
 16:21:03.598 [Exception... "Failure"  nsresult: "0x80004005
 (NS_ERROR_FAILURE)"  location: "JS frame ::
 chrome://noscript/content/Restartless.jsm?0.5651077320914104.1507411556800
 :: loadIntoWindow :: line 193"  data: no] 1 (unknown)
         loadIntoWindow chrome://noscript/content/Restartless.jsm:193:5
         observe chrome://noscript/content/Restartless.jsm:218:11
 16:21:03.599 Could not overlay chrome://browser/content/browser.xul 1
 Restartless.jsm:224
         loadIntoWindow chrome://noscript/content/Restartless.jsm:224:5
         observe chrome://noscript/content/Restartless.jsm:218:11
 [10-10 16:21:04] Torbutton INFO: New window
 }}}
 because you try to do that before first window is created.

 Also [https://trac.torproject.org/projects/tor/ticket/22324#comment:4
 this]

 Also don't ignore
 [https://trac.torproject.org/projects/tor/query?status=!closed&keywords=~noscript
 this]

 It's better to release this with ESR52.4.1 in order to include into the
 next TBB update.

 gk:
 {{{
 15:29:21.053 Unchecked lastError value: Error: Invalid tab ID: 194 1
 ExtensionCommon.jsm:265
         withLastError resource://gre/modules/ExtensionCommon.jsm:265:9
         wrapPromise/< resource://gre/modules/ExtensionCommon.jsm:316:11
         torbutton_send_ctrl_cmd
 chrome://torbutton/content/torbutton.js:868:10
         torbutton_do_new_identity
 chrome://torbutton/content/torbutton.js:1223:10
         torbutton_new_identity
 chrome://torbutton/content/torbutton.js:961:9
         oncommand chrome://browser/content/browser.xul:1:1
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23724#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online