[tbb-bugs] #24477 [Applications/Tor Browser]: Windows 64 mar files are not generated

[Tor Bug Tracker & Wiki]

#24477: Windows 64 mar files are not generated
--------------------------------------+--------------------------
 Reporter:  boklm                     |          Owner:  tbb-team
     Type:  defect                    |         Status:  new
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201711      |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:  Sponsor4
--------------------------------------+--------------------------

Comment (by boklm):

 Replying to [comment:1 boklm]:
 > However we then have an error with `pe_checksum_fix.py` which doesn't
 work in 64bit:
 > {{{
 > Traceback (most recent call last):
 >   File "/var/tmp/tmp.oYuOVB2u7o/pe_checksum_fix.py", line 55, in
 <module>
 >     pef.OPTIONAL_HEADER.CheckSum = pef.generate_checksum()
 >   File "/usr/lib/python2.7/dist-packages/pefile.py", line 3720, in
 generate_checksum
 >     dword = struct.unpack('L', self.__data__[ i*4 : i*4+4 ])[0]
 > struct.error: unpack requires a string argument of length 8
 > }}}
 >
 > I think we can fix that by installing a more recent version of python-
 pefile, as done before commit bb32ec91b538ab17d309b645787149ff376d58e9.

 I tried to do that with this patch:
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_24477&id=2bd73ca5c7ff5036dac8f562ba2fae36717519e4

 However I am still getting a similar error:
 {{{
   File "/var/tmp/tmp.f4UwWTvuwY/pe_checksum_fix.py", line 55, in <module>
     pef.OPTIONAL_HEADER.CheckSum = pef.generate_checksum()
   File "/var/tmp/tmp.f4UwWTvuwY/.local/lib/python2.7/site-
 packages/pefile.py", line 5418, in generate_checksum
     dword = struct.unpack('I', self.__data__[ i*4 : i*4+4 ])[0]
 struct.error: unpack requires a string argument of length 4
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24477#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online