[tbb-bugs] #24361 [Applications/rbm]: rbm gives an error if a build script contains a wide character
Tor Bug Tracker & Wiki
blackhole at torproject.org
Mon Nov 27 11:49:54 UTC 2017
#24361: rbm gives an error if a build script contains a wide character
--------------------------------------------+------------------------
Reporter: boklm | Owner: boklm
Type: defect | Status: closed
Priority: Medium | Milestone:
Component: Applications/rbm | Version:
Severity: Normal | Resolution: fixed
Keywords: tbb-rbm, TorBrowserTeam201711R | Actual Points:
Parent ID: #21998 | Points:
Reviewer: | Sponsor:
--------------------------------------------+------------------------
Comment (by gk):
Replying to [comment:7 boklm]:
> Replying to [comment:6 gk]:
> >
> > > After merging this commit, we will also need to update the README
file in `tor-browser-build` to add `Path::Tiny` / `libpath-tiny-perl` to
the list of dependencies, and removing `File::Slurp` / `libfile-slurp-
perl`.
> >
> > Done in commit a6d54303ad89af777a4994dc27d0ae90945f090c on `master`. I
adapted `main.yml` as well.
>
> I fixed the package name (File::Tiny => Path::Tiny) in commit
39b88a7e8b03877bf478cafd1b72e9abc5694ca6.
Ugh, sorry. I applied a fixup to clean up the remaining `read_file()` in
commit 5c89374df7957238a9565c0b938ee3f30f880438 the `rbm` repo and bumped
the `rbm` revision in `tor-browser-build` in commit
57b65bcc24372b0d7eaff35bd8cf5089fd33b035. I hope we are finally done here
now. :)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24361#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tbb-bugs
mailing list