[tbb-bugs] #22415 [Applications/Tor Browser]: Format error in our pipeline patch

Tor Bug Tracker & Wiki blackhole at torproject.org
Sat May 27 08:46:18 UTC 2017


#22415: Format error in our pipeline patch
------------------------------------------+--------------------------------
     Reporter:  arthuredelstein           |      Owner:  tbb-team
         Type:  defect                    |     Status:  new
     Priority:  Medium                    |  Milestone:
    Component:  Applications/Tor Browser  |    Version:
     Severity:  Normal                    |   Keywords:
                                          |  TorBrowserTeam201705
Actual Points:                            |  Parent ID:
       Points:                            |   Reviewer:
      Sponsor:                            |
------------------------------------------+--------------------------------
 I was building tor-browser.git with -Werror=format and it revealed a
 format error in our #5282 patch. The line is
 {{{
       fprintf(stderr, "WTF-combine: Sent %lld/%lld bytes of %lld combined
 pipelined requests for host %s\n",
               alreadyPending+totalSent, totalAvailable, reqsSent,
 ci->Origin());
 }}}
 But the first three arguments after the format string are unsigned long
 integers, not long long integers.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22415>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tbb-bugs mailing list