[tbb-bugs] #21704 [Applications/Tor Browser]: Warn users when installing Tor Browser based on ESR 52 on not SSE2 capable Windows machines

[Tor Bug Tracker & Wiki]

#21704: Warn users when installing Tor Browser based on ESR 52 on not SSE2 capable
Windows machines
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  boklm
     Type:  enhancement                          |         Status:
                                                 |  assigned
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff52-esr, TorBrowserTeam201706,      |  Actual Points:
  tbb-7.0-must                                   |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor4
-------------------------------------------------+-------------------------

Comment (by boklm):

 I attached a patch for `tbb-windows-installer.git` that I think should
 abort installation with a message if the CPU does not support SSE2.

 The line using `kernel32::IsProcessorFeaturePresent` to check whether the
 SSE2 instruction set is available was taken from the firefox installer in
 `browser/installer/windows/nsis/installer.nsi`.

 I made a build with this patch:
 https://people.torproject.org/~boklm/bug_21704/torbrowser-install-7
 .0a4_en-US.exe
 https://people.torproject.org/~boklm/bug_21704/torbrowser-install-7
 .0a4_en-US.exe.asc

 On my Windows VM with SSE2 support, the installation is working as before.
 Unfortunately I don't have a machine without SSE2 support to check that
 the message is displayed and installation aborted in that case.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21704#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online