[tbb-bugs] #22831 [Applications/Tor Browser]: Merge Snowflake for mac
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Jul 18 12:26:19 UTC 2017
#22831: Merge Snowflake for mac
---------------------------------------------+--------------------------
Reporter: dcf | Owner: tbb-team
Type: task | Status: closed
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution: fixed
Keywords: snowflake TorBrowserTeam201707R | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
---------------------------------------------+--------------------------
Comment (by dcf):
Replying to [comment:7 boklm]:
> When looking at commit fcdc2be0a2da32a939e172564300d5a09259b75e, I
noticed this line in `gitian/descriptors/mac/gitian-webrtc.yml`:
> {{{
> GN_ARGS+=" gold_path=\"$INSTDIR/binutils/bin\""
> }}}
>
> However, I don't think we have a binutils installed in this path in the
mac build. Is it a line that was copied from the linux descriptor and
forgotten?
Yes, it is probably a copy-paste error. The `GN_ARGS` in both descriptors
are probably not minimal. The compile–test cycles are so long that I would
try changing more than one thing at a time.
If you find that the line is unnecessary, please remove it.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22831#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tbb-bugs
mailing list