[tbb-bugs] #21309 [Applications/Tor Browser]: Fix Omnibox for TBB/52ESR

[Tor Bug Tracker & Wiki]

#21309: Fix Omnibox for TBB/52ESR
--------------------------------------------+------------------------------
 Reporter:  arthuredelstein                 |          Owner:  tbb-team
     Type:  defect                          |         Status:  needs_review
 Priority:  Medium                          |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  ff52-esr, TorBrowserTeam201702  |  Actual Points:
Parent ID:  #20680                          |         Points:
 Reviewer:                                  |        Sponsor:  Sponsor4
--------------------------------------------+------------------------------

Comment (by arthuredelstein):

 Replying to [comment:10 mcs]:
 > Replying to [comment:9 arthuredelstein]:
 > > Unfortunately it doesn't work -- the language packs each contains a
 list.json file that overrides these settings. So we'll need to update the
 #18915 patch as I mentioned in comment:7.
 >
 > Here is a radical idea: modify browser/locales/search/list.json to only
 contain a "default" entry and remove the list.json file from each language
 pack during our packaging phase. I don't know if everything would work
 correctly if we did that, but it might.

 For some reason removing all but the default entry doesn't work, even for
 US English. nsSearchService.js is pretty convoluted so I'm not sure why.
 My current approach is to change all locales we deploy to include the same
 search engine list, and then rely on our #18915 patches for tor-browser-
 bundle.git to copy these search engines and the list to each locale xpi.
 It's awkward, but it seems like it should work. Unfortunately I'm having
 trouble getting tor-browser-bundle.git to build right now, so I haven't
 fully tested this. But here is the patch in any case:

 https://github.com/arthuredelstein/tor-browser/commit/21309+1

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21309#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online