[tbb-bugs] #21309 [Applications/Tor Browser]: Fix Omnibox for TBB/52ESR

[Tor Bug Tracker & Wiki]

#21309: Fix Omnibox for TBB/52ESR
--------------------------------------------+------------------------------
 Reporter:  arthuredelstein                 |          Owner:  tbb-team
     Type:  defect                          |         Status:  needs_review
 Priority:  Medium                          |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  ff52-esr, TorBrowserTeam201702  |  Actual Points:
Parent ID:  #20680                          |         Points:
 Reviewer:                                  |        Sponsor:  Sponsor4
--------------------------------------------+------------------------------

Comment (by arthuredelstein):

 Replying to [comment:8 mcs]:
 > Do you know if the `browser.search.*` prefs are set from the values that
 are included in `browser/locales/search/list.json`?

 Yes, they appear to be.

 > Also, do we need to change the en-US `US` and `CA` entries in that file?
 I assume the browser uses the `US` entries if it detects that the user is
 located in the USA and CA if in Canada (although maybe we disabled that
 kind of location detection? I cannot remember).

 I believe that location detection is disabled, because we have
 browser.search.geoSpecificDefaults set to false.

 > For non-en-US locales, will it work to just patch
 `browser/locales/search/list.json` for each locale that we care to change?
 That won't work if the language packs override those settings though.

 Unfortunately it doesn't work -- the language packs each contains a
 list.json file that overrides these settings. So we'll need to update the
 #18915 patch as I mentioned in comment:7.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21309#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online