[tbb-bugs] #20111 [Applications/Tor Browser]: use Unix domain sockets for SOCKS port by default

[Tor Bug Tracker & Wiki]

#20111: use Unix domain sockets for SOCKS port by default
-------------------------------------------------+-------------------------
 Reporter:  mcs                                  |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_information
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton, tbb-security,         |  Actual Points:
  TorBrowserTeam201609R                          |
Parent ID:  #14270                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => needs_information


Comment:

 When testing your patches in a clean, new hardened build I got the
 following issue:
 {{{
 Sep 28 11:34:45.000 [warn] tor_bug_occurred_(): Bug:
 src/common/address.c:1119: tor_addr_compare_masked: This line should not
 have been reached. (Future instances of this warning will be silenced.)
 (on Tor 0.2.9.2-alpha 00ec701f8343f552)
 Sep 28 11:34:45.000 [warn] Bug: Line unexpectedly reached at
 tor_addr_compare_masked at src/common/address.c:1119. Stack trace: (on Tor
 0.2.9.2-alpha 00ec701f8343f552)
 Sep 28 11:34:45.000 [warn] Bug:
 /home/thomas/Arbeit/Tor/debugging/20111/tor-
 browser/Browser/TorBrowser/Tor/libasan.so.2(+0x4bc88) [0x7fa4d26eac88] (on
 Tor 0.2.9.2-alpha 00ec701f8343f552)
 Sep 28 11:34:45.000 [warn] Bug:
 /home/thomas/Arbeit/Tor/debugging/20111/tor-
 browser/Browser/TorBrowser/Tor/tor(log_backtrace+0x46) [0x560e0b946df6]
 (on Tor 0.2.9.2-alpha 00ec701f8343f552)
 Sep 28 11:34:45.000 [warn] Bug:
 /home/thomas/Arbeit/Tor/debugging/20111/tor-
 browser/Browser/TorBrowser/Tor/tor(tor_bug_occurred_+0x13b)
 [0x560e0b99423b] (on Tor 0.2.9.2-alpha 00ec701f8343f552)
 Sep 28 11:34:45.000 [warn] Bug:
 /home/thomas/Arbeit/Tor/debugging/20111/tor-
 browser/Browser/TorBrowser/Tor/tor(tor_addr_compare_masked+0x455)
 [0x560e0b941105] (on Tor 0.2.9.2-alpha 00ec701f8343f552)
 Sep 28 11:34:45.000 [warn] Bug:
 /home/thomas/Arbeit/Tor/debugging/20111/tor-
 browser/Browser/TorBrowser/Tor/tor(connection_edge_compatible_with_circuit+0x2a3)
 [0x560e0b866873] (on Tor 0.2.9.2-alpha 00ec701f8343f552)
 Sep 28 11:34:45.000 [warn] Bug:
 /home/thomas/Arbeit/Tor/debugging/20111/tor-
 browser/Browser/TorBrowser/Tor/tor(+0x73a276) [0x560e0b7d5276] (on Tor
 0.2.9.2-alpha 00ec701f8343f552)
 Sep 28 11:34:45.000 [warn] Bug:
 /home/thomas/Arbeit/Tor/debugging/20111/tor-
 browser/Browser/TorBrowser/Tor/tor(+0x749a3a) [0x560e0b7e4a3a] (on Tor
 0.2.9.2-alpha 00ec701f8343f552)
 Sep 28 11:34:45.000 [warn] Bug:
 /home/thomas/Arbeit/Tor/debugging/20111/tor-
 browser/Browser/TorBrowser/Tor/tor(connection_ap_handshake_attach_circuit+0x722)
 [0x560e0b7e6e22] (on Tor 0.2.9.2-alpha 00ec701f8343f552)
 Sep 28 11:34:45.000 [warn] Bug:
 /home/thomas/Arbeit/Tor/debugging/20111/tor-
 browser/Browser/TorBrowser/Tor/tor(connection_ap_attach_pending+0x4ac)
 [0x560e0b85707c] (on Tor 0.2.9.2-alpha 00ec701f8343f552)
 Sep 28 11:34:45.000 [warn] Bug:
 /home/thomas/Arbeit/Tor/debugging/20111/tor-
 browser/Browser/TorBrowser/Tor/tor(circuit_build_needed_circs+0xe7)
 [0x560e0b7e38a7] (on Tor 0.2.9.2-alpha 00ec701f8343f552)
 Sep 28 11:34:45.000 [warn] Bug:
 /home/thomas/Arbeit/Tor/debugging/20111/tor-
 browser/Browser/TorBrowser/Tor/tor(+0x552488) [0x560e0b5ed488] (on Tor
 0.2.9.2-alpha 00ec701f8343f552)
 Sep 28 11:34:45.000 [warn] Bug:
 /home/thomas/Arbeit/Tor/debugging/20111/tor-
 browser/Browser/TorBrowser/Tor/libevent-2.0.so.5(event_base_loop+0x937)
 [0x7fa4d1f488d7] (on Tor 0.2.9.2-alpha 00ec701f8343f552)
 Sep 28 11:34:45.000 [warn] Bug:
 /home/thomas/Arbeit/Tor/debugging/20111/tor-
 browser/Browser/TorBrowser/Tor/tor(do_main_loop+0x398) [0x560e0b5ee898]
 (on Tor 0.2.9.2-alpha 00ec701f8343f552)
 Sep 28 11:34:45.000 [warn] Bug:
 /home/thomas/Arbeit/Tor/debugging/20111/tor-
 browser/Browser/TorBrowser/Tor/tor(tor_main+0x140d) [0x560e0b5f3a3d] (on
 Tor 0.2.9.2-alpha 00ec701f8343f552)
 Sep 28 11:34:45.000 [warn] Bug:
 /home/thomas/Arbeit/Tor/debugging/20111/tor-
 browser/Browser/TorBrowser/Tor/tor(main+0x1c) [0x560e0b5e102c] (on Tor
 0.2.9.2-alpha 00ec701f8343f552)
 Sep 28 11:34:45.000 [warn] Bug:     /lib/x86_64-linux-
 gnu/libc.so.6(__libc_start_main+0xf0) [0x7fa4d0195700] (on Tor
 0.2.9.2-alpha 00ec701f8343f552)
 Sep 28 11:34:45.000 [warn] Bug:
 /home/thomas/Arbeit/Tor/debugging/20111/tor-
 browser/Browser/TorBrowser/Tor/tor(+0x547dcd) [0x560e0b5e2dcd] (on Tor
 0.2.9.2-alpha 00ec701f8343f552)
 }}}
 Do you see the same on your machines? It seems we are hitting a tor bug or
 is there something wrong with your patches (they looked reasonable to me
 after the first code-review pass).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20111#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online