[tbb-bugs] #20388 [Applications/Tor Browser]: Consolidate prefs usage in torbutton.js

[Tor Bug Tracker & Wiki]

#20388: Consolidate prefs usage in torbutton.js
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  closed
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Minor                                |     Resolution:  fixed
 Keywords:  tbb-code-cleanup,                    |  Actual Points:
  TorBrowserTeam201610R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by arthuredelstein):

 Replying to [comment:5 bugzilla]:
 > Replying to [comment:4 mcs]:
 > > Replying to [comment:3 bugzilla]:
 > > > Minor thing about prefs usage in torbutton.js:
 `extensions.torbutton.lastUpdateCheck` is set to `1475974589.6` instead of
 `1475974589600`.
 > >
 > > Does this cause buggy behavior or is it just surprising that
 `Date.now() / 1000` is stored without rounding to an integer?
 > All other prefs with `lastUpdate` use integers. If you treat e.g.
 milliseconds as microseconds somewhere, it may lead to some surprises.

 I would like to keep a new issue such as this one in a separate ticket so
 we don't lose it. That being said, all "lastUpdate" prefs on my TBB are in
 units of seconds, either rounded or not. What is unusual is that this is a
 string pref instead of an integer pref, but I don't think that is a
 problem.

--
Ticket URL: <https://troodi.torproject.org/projects/tor/ticket/20388#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online