[tbb-bugs] #20111 [Applications/Tor Browser]: use Unix domain sockets for SOCKS port by default

[Tor Bug Tracker & Wiki]

#20111: use Unix domain sockets for SOCKS port by default
-------------------------------------------------+-------------------------
 Reporter:  mcs                                  |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton, tbb-security, tbb-    |  Actual Points:
  sandboxing, TorBrowserTeam201610R              |
Parent ID:  #14270                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by mcs):

 Replying to [comment:20 arthuredelstein]:
 > A few very minor comments:
 >
 > * "extensions.torlauncher.socks_port_use_socket" is a confusing name to
 me, because we are using a TCP socket when it is false. Maybe call it
 "socks_port_use_ipc", as this would also cover the named pipe scenario if
 we later get it working in Windows? Similar for the env var
 TOR_SOCKS_SOCKET.

 Good point. Kathy and I cleaned this up. We renamed the env vars and
 preferences as well as various functions and variables. The changes are a
 little messy, but they seem worthwhile.

 > * `_strUnescape`: It would be nicer if this function simply returned the
 unescaped string, and threw an exception if it failed. (Although maybe you
 want to keep it this way to be consistent with the other copy in Tor
 launcher.)

 Done. While testing, we also found some errors in the implementation
 (oops).

 > * `unescapeTorString`: I would suggest defining this after
 `_strUnescape` is defined in utils.js, because it refers to it.

 Done.

 Revised patches for Tor Launcher and Torbutton:
 https://gitweb.torproject.org/user/brade/tor-
 launcher.git/commit/?h=bug20111-04&id=e0e8798adf793b1a369430292b881bf3cbbd6693
 https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug20111-03&id=d66fa277a83b4a117669f6ee8e86591b2988ec22

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20111#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online