[tbb-bugs] #16351 [Applications/Tor Browser]: Upgrade our toolchain for Tor Browser 5.0
Tor Bug Tracker & Wiki
blackhole at torproject.org
Sat Oct 8 17:49:12 UTC 2016
#16351: Upgrade our toolchain for Tor Browser 5.0
-------------------------------------------------+-------------------------
Reporter: gk | Owner: tbb-
| team
Type: enhancement | Status: closed
Priority: Medium | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution: fixed
Keywords: tbb-gitian, GeorgKoppen201506, | Actual Points:
tbb-5.0a3-essential, TorBrowserTeam201507R |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Changes (by bugzilla):
* severity: => Normal
Comment:
Replying to [comment:6 boklm]:
> r=boklm
> The gitian/patches/enable-reloc-section-ld.patch file looks good to me
(I had previously rebased it on the new binutils and got the same patch).
Safer approaches:
> You can also pass --dynamicbase to the linker in the same way, but sadly
it doesn't emit the necessary relocation table. As a workaround, you can
pass -Wl,--dynamicbase,--export-all-symbols. An explicit
__declspec(dllexport) of a single symbol like main also works, and that is
currently the workaround used in the Rust compiler.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16351#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tbb-bugs
mailing list