[tbb-bugs] #20758 [Applications/Tor Browser]: Make Linux sandbox build deterministic

[Tor Bug Tracker & Wiki]

#20758: Make Linux sandbox build deterministic
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  TorBrowserTeam201611R,               |  Actual Points:
  GeorgKoppen201611                              |
Parent ID:  #19750                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by yawning):

 Replying to [comment:3 gk]:
 > Okay this was easier than thought: bug_20758
 (https://gitweb.torproject.org/user/gk/tor-browser-
 bundle.git/commit/?h=bug_20758&id=e440393104ee04128a8660fecd0cce2f25bcaed8)
 in my tor-browser-bundle repo has a fix for review. It solves all the
 problems I encountered while doing several builds of the sandbox on the
 same machine and comparing the outputs. It is atop of the patches for
 #20352.

 Looks ok to me.

 If you're interested in nitpicking (though this probably won't get
 upstreamed):

  * Run `go fmt` prior to add/commit to reformat the source code (The
 commit message mentioned indentation).
  * I'd probably do something like:
 {{{
   workdir := filepath.Join(os.TempDir(), "gb")
   err := os.Mkdir(workdir, 0777)
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20758#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online