[tbb-bugs] #20352 [Applications/Tor Browser]: Integrate sandboxed Tor Browser into our gitian build system

[Tor Bug Tracker & Wiki]

#20352: Integrate sandboxed Tor Browser into our gitian build system
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:  new
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-gitian, tbb-sandboxing,          |  Actual Points:
  GeorgKoppen201611, TorBrowserTeam201611        |
Parent ID:  #19750                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by yawning):

 Replying to [comment:5 gk]:
 > The compiler does not like your stub code it seems:
 > {{{
 > gcc -shared -pthread -Os -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-
 protector-all -Wstack-protector --param ssp-buffer-size=1 -fPIC -Wall
 -Werror -Wextra -Wl,-z,relro,-z,now src/tbb_stub/tbb_stub.c -o
 data/tbb_stub.so
 > src/tbb_stub/tbb_stub.c: In function 'stub_init':
 > src/tbb_stub/tbb_stub.c:197:3: error: implicit declaration of function
 'secure_getenv' [-Werror=implicit-function-declaration]
 > src/tbb_stub/tbb_stub.c:197:22: error: initialization makes pointer from
 integer without a cast [-Werror]
 > src/tbb_stub/tbb_stub.c:198:24: error: initialization makes pointer from
 integer without a cast [-Werror]
 > cc1: all warnings being treated as errors
 > make: *** [tbb_stub] Error 1
 > }}}

 As discussed on irc:
 `secure_getenv() first appeared in glibc 2.17.`

 I could just as easily use `getenv()`, or pull in the `secure_getenv()`
 symbol via `dlsym()`, but I think that it is reasonable to use calls that
 have been in glibc since December 2012.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20352#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online