[tbb-bugs] #20556 [Applications/Tor bundles/installation]: pt-PT Tor Browser bundles are diguised pt-BR bundles

[Tor Bug Tracker & Wiki]

#20556: pt-PT Tor Browser bundles are diguised pt-BR bundles
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor                     |        Version:
  bundles/installation                           |
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-usability,                       |  Actual Points:
  TorBrowserTeam201611R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:9 boklm]:
 > I see that in torbutton and tor-launcher, we have both `pt` and `pt-BR`
 containing differents translations:
 > https://gitweb.torproject.org/torbutton.git/tree/src/chrome/locale/pt
 > https://gitweb.torproject.org/torbutton.git/tree/src/chrome/locale/pt-BR
 > https://gitweb.torproject.org/tor-launcher.git/tree/src/chrome/locale/pt
 > https://gitweb.torproject.org/tor-launcher.git/tree/src/chrome/locale
 /pt-BR
 >
 > Were we using the `pt` one before, and this change makes us use the `pt-
 BR` one now?

 No, I don't think so. I guess what happens is the following: we ship `pt-
 PT` bundles now but looking at the above links there is no so locale.
 Rather, we only have `pt` and `pt-BR`. The code is presumably falling back
 to `pt` (I have not checked that) which turns out to be `pt-BR` which we
 import during translation updates. I guess the same is happening with Tor
 Launcher. Now, the interesting part is what is going to happen if we
 switch to `pt-BR` officially? Then we probably use the `pr-BR` branch even
 though we only update the `pt` one every time. I guess we need to update
 the locale import scripts as well...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20556#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online