[tbb-bugs] #18914 [Applications/Tor Browser]: Consider removing <isindex>

[Tor Bug Tracker & Wiki]

#18914: Consider removing <isindex>
---------------------------------------------+-----------------------------
 Reporter:  mcs                              |          Owner:  tbb-team
     Type:  defect                           |         Status:
 Priority:  Medium                           |  needs_review
Component:  Applications/Tor Browser         |      Milestone:
 Severity:  Normal                           |        Version:
 Keywords:  ff45-esr, TorBrowserTeam201605R  |     Resolution:
Parent ID:                                   |  Actual Points:
 Reviewer:                                   |         Points:
                                             |        Sponsor:
---------------------------------------------+-----------------------------

Comment (by mcs):

 Replying to [comment:3 arthuredelstein]:
 > Here's a patch that uses an English-only label on `<isindex/>` tags. The
 localized tag is removed. This provides an easy fix while we wait for
 Mozilla to remove the <isindex> support altogether.
 >
 > https://github.com/arthuredelstein/tor-browser/commit/18914+1
 > Hash 018cc9788c202df10a9f6aceaac12af12bd672b6

 This is a good solution.
 Is it safe to use u"..." string literals for all compilers?
 Mozilla code usually uses NS_LITERAL_STRING.
 Otherwise, the changes look good.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18914#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online