[tbb-bugs] #18632 [Tor Browser]: Rewritten Image Cache isolation patch for TBB/ESR45

[Tor Bug Tracker & Wiki]

#18632: Rewritten Image Cache isolation patch for TBB/ESR45
-----------------------------+------------------------------
 Reporter:  arthuredelstein  |          Owner:  tbb-team
     Type:  defect           |         Status:  needs_review
 Priority:  Medium           |      Milestone:
Component:  Tor Browser      |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:  #15197           |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------

Comment (by mcs):

 Overall, this looks good. Kathy and I have a couple of questions:

 1) The old patch had the concept that isolation may not be possible, in
 which case the images where not added to the cache, e.g.
 {{{
   if (isIsolated)
     PutIntoCache();
 }}}
 Can you explain why that concept is no longer needed? Is it because
 everything should be isolated (since a document is always available when
 generating the cache key)?

 2) Have you run the automated tests? How much manual testing have you
 done? Kathy and I did not build or run with the new patch yet.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18632#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online