[tbb-bugs] #19532 [Applications/Tor Browser]: nsXREDirProvider breaks Orfox

[Tor Bug Tracker & Wiki]

#19532: nsXREDirProvider breaks Orfox
----------------------------------------------+----------------------------
 Reporter:  amoghbl1                          |          Owner:  tbb-team
     Type:  defect                            |         Status:
 Priority:  Medium                            |  needs_information
Component:  Applications/Tor Browser          |      Milestone:
 Severity:  Normal                            |        Version:
 Keywords:  tbb-mobile, TorBrowserTeam201607  |     Resolution:
Parent ID:                                    |  Actual Points:
 Reviewer:                                    |         Points:
                                              |        Sponsor:
----------------------------------------------+----------------------------

Comment (by mcs):

 Replying to [comment:7 amoghbl1]:
 > I've attached the nsXREDirProvider file along with a few spelling
 mistakes in comments because the trac was blocking it with it's spam
 filters.

 That file is not the same as the tor-browser-45.2.0esr-6.5-1-build1 file,
 which is this one:
  https://gitweb.torproject.org/tor-
 browser.git/plain/toolkit/xre/nsXREDirProvider.cpp?id=b60b8871fa08feaaca24bcf6dff43df0cd1c5f29

 It looks like you (or someone) backed out portions of various Tor Browser
 commits. Do you know why that was done? If changes are necessary, we
 should find a way to make them with #ifdef's so that the same file can be
 used by Orfox and Tor Browser. I think the compile error is caused by
 changes made during the backout process, although it is difficult to be
 certain without know what was backed out and why.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19532#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online