[tbb-bugs] #16990 [Tor Browser]: Circuit visualizer stops working after some time

[Tor Bug Tracker & Wiki]

#16990: Circuit visualizer stops working after some time
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:  tbb-
     Type:  defect                               |  team
 Priority:  Medium                               |         Status:
Component:  Tor Browser                          |  assigned
 Severity:  Normal                               |      Milestone:
 Keywords:  tbb-torbutton tbb-circuit-display    |        Version:
  TorBrowserTeam201601                           |     Resolution:
Parent ID:                                       |  Actual Points:
  Sponsor:                                       |         Points:
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:  tbb-torbutton tbb-circuit-display TorBrowserTeam201601R,
     tbb-5.5 => tbb-torbutton tbb-circuit-display TorBrowserTeam201601
 * status:  needs_review => assigned


Comment:

 Replying to [comment:24 arthuredelstein]:
 > Replying to [comment:23 gk]:
 > > I applied c3cb05997d0ac0f54f431d71ae8852d79b865756. Wrt
 41ce4aa0ba211f610a7a64315d3abf95cddaf16f. Looks mostly good. I just
 stumbled over "and stopped when it set to false". "is set to false"? Oh,
 you carefully worked above and below
 > > {{{
 > > // Check if we have anything to show for these credentials.
 > > }}}
 > > without adapting the indentation of this comment. :) Could you fix
 that, too, while fixing the typo above?
 >
 > Thanks for catching these. Here is the patch with these things fixed:
 > https://github.com/arthuredelstein/torbutton/commit/16690+2

 Thanks, this is commit 53299a96c848d806d490e3b7068d81be352d7620 on master.

 Taking this off of our tbb-5.5 radar as the bug causing the reopening is
 still around and a fix won't make it into 5.5.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16990#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online