[tbb-bugs] #17931 [Tor Browser]: Tor Browser Hardened Crash

[Tor Bug Tracker & Wiki]

#17931: Tor Browser Hardened Crash
-------------------------------------------------+-------------------------
 Reporter:  pege                                 |          Owner:  tbb-
     Type:  defect                               |  team
 Priority:  Immediate                            |         Status:
Component:  Tor Browser                          |  needs_revision
 Severity:  Blocker                              |      Milestone:
 Keywords:  tbb-hardened, tbb-crash,             |        Version:
  TorBrowserTeam201512R                          |     Resolution:
Parent ID:                                       |  Actual Points:
  Sponsor:                                       |         Points:
-------------------------------------------------+-------------------------

Comment (by arthuredelstein):

 Here are two patches to give `nsContentUtils::LogMessageToConsole` a
 single non-format argument, as Mike suggested:

 https://github.com/arthuredelstein/tor-browser/commits/17931+2

 The first patch removes usage of `LogMessageToConsole` in
 `GonkGPSGeolocationProvider.cpp`, in favor of a more standard logging
 method found in other Gonk files.

 The second patch changes `nsContentUtils::LogMessageToConsole` to a single
 argument. That makes the existing usage in `nsCanvasUtils.cpp` and
 `loggingCallbacks.h` safe.

 I confirmed that tor-browser.git builds and works with these patches
 applied. I have also submitted them to Mozilla's try server. The results
 will be here:
 https://treeherder.mozilla.org/#/jobs?repo=try&revision=00333f0503d1

 As I mentioned on IRC, I'm very sorry for causing this bug. I do agree
 with Mike that it will be safer if Mozilla adopts a single-argument
 signature for `LogMessageToConsole`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17931#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online