[tbb-bugs] #16220 [Applications/Tor Browser]: Torbutton/Torlauncher flips out if TOR_SKIP_LAUCH is set without TOR_SOCKS_PORT

[Tor Bug Tracker & Wiki]

#16220: Torbutton/Torlauncher flips out if TOR_SKIP_LAUCH is set without
TOR_SOCKS_PORT
--------------------------------------+--------------------------
 Reporter:  yawning                   |          Owner:  tbb-team
     Type:  defect                    |         Status:  new
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:                            |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------
Changes (by mcs):

 * severity:   => Normal


Comment:

 Now that #15852 has been fixed, I took another look at this ticket. But it
 is not fixed because we kept the code in Torbutton that sets
 network.proxy.socks_port to 9050 when the browser is started with
 TOR_SOCKS_PORT=9050. So the control port check is correct: the proxy is
 misconfigured if you are really running it on 9150.

 I do not know how to fix this without making the effect of the env vars
 temporary, which would be difficult to do in a way that is "bulletproof"
 (or crash-proof at least).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16220#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online