[tbb-bugs] #18632 [Tor Browser]: Rewritten Image Cache isolation patch for TBB/ESR45

[Tor Bug Tracker & Wiki]

#18632: Rewritten Image Cache isolation patch for TBB/ESR45
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:  tbb-
     Type:  defect                               |  team
 Priority:  Medium                               |         Status:
Component:  Tor Browser                          |  needs_information
 Severity:  Normal                               |      Milestone:
 Keywords:  TorBrowserTeam201604R, ff45-esr,     |        Version:
  tbb-6.0a5                                      |     Resolution:
Parent ID:  #15197                               |  Actual Points:
 Reviewer:                                       |         Points:
                                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by arthuredelstein):

 Replying to [comment:2 mcs]:
 > Overall, this looks good. Kathy and I have a couple of questions:
 >
 > 1) The old patch had the concept that isolation may not be possible, in
 which case the images where not added to the cache, e.g.
 > {{{
 >   if (isIsolated)
 >     PutIntoCache();
 > }}}
 >
 > Can you explain why that concept is no longer needed? Is it because
 everything should be isolated (since a document is always available when
 generating the cache key)?

 Now I think it is needed... So I have added a fixup patch in
 https://github.com/arthuredelstein/tor-browser/commits/15197+12
 hash: ee7e5be3df465a9b32690e767796a3e258ef81b0

 > 2) Have you run the automated tests? How much manual testing have you
 done? Kathy and I did not build or run with the new patch yet.

 I have run the automated regression tests we wrote, and images appear to
 be cached correctly. I have also visited various sites and images
 manually, and it appears the images are landing in the cache with the
 correct first-party key.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18632#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online