[tbb-bugs] #17568 [Tor Browser]: Clean up tor-control-port.js in Torbutton
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Nov 17 16:25:37 UTC 2015
#17568: Clean up tor-control-port.js in Torbutton
-------------------------------------------------+-------------------------
Reporter: gk | Owner: tbb-
Type: task | team
Priority: Medium | Status:
Component: Tor Browser | needs_revision
Severity: Normal | Milestone:
Keywords: tbb-torbutton, | Version:
TorBrowserTeam201511R | Resolution:
Parent ID: | Actual Points:
Sponsor: | Points:
-------------------------------------------------+-------------------------
Comment (by gk):
I think the following two RegExes could get cleaned up as well:
`new RegExp("^650." + type, "i")`
`/^650 \S+?\s(.*?)$/m`
The latter according to the other clean-up done in your 17568 branch. For
the former, according to the spec use-case the reply is "650 STREAM", so
nothing case-sensitive should be needed and having a white space after
"650" is defined as well.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17568#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tbb-bugs
mailing list