[tbb-bugs] #15406 [Tor Browser]: Patch make_incremental_update.sh to only include forced updates if they differ?

[Tor Bug Tracker & Wiki]

#15406: Patch make_incremental_update.sh to only include forced updates if they
differ?
-------------------------------------------------+-------------------------
 Reporter:  mikeperry                            |          Owner:  tbb-
     Type:  defect                               |  team
 Priority:  normal                               |         Status:  new
Component:  Tor Browser                          |      Milestone:
 Keywords:  tbb-4.5-alpha, TorBrowserTeam201503  |        Version:
Parent ID:                                       |  Actual Points:
                                                 |         Points:
-------------------------------------------------+-------------------------
 I read through make_incremental_update.sh a bit closer while cleaning up
 my patch for bug13375, and I am concerned that $requested_forced_updates
 and the associated check_for_forced_update() is going to cause a lot of
 unnecessary load on the Tor network due to including full copies of all of
 our addons regardless of if they change.

 Can we make check_for_forced_update() only include full copies of stuff
 from the forced_update line if it has actually changed between releases? I
 notice that the original code also forced
 Contents/MacOS/TorBrowser.app/Contents/MacOS/firefox. I'm not sure if we
 should continue to treat that as full copies regardless of change.
 Possibly?

 Is there substantial risk for trying to do this change for 4.5a5? The
 change itself seems simple enough to me (just use the diff check from the
 next block in a conjunction).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15406>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online