[tbb-bugs] #15086 [Tor Browser]: tor circuit display has text positioning/alignment problems for RTL languages

[Tor Bug Tracker & Wiki]

#15086: tor circuit display has text positioning/alignment problems for RTL
languages
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  tbb-team
  arthuredelstein        |     Status:  needs_revision
         Type:  defect   |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-circuit-display, tbb-usability,
  Browser                |  TorBrowserTeam201503R, GeorgKoppen201503R
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by arthuredelstein):

 Replying to [comment:4 gk]:
 > Looks good. I'd like to get two nits fixed:
 >
 > 1)
 > {{{
 > // Updates the Tor circuit display SVG, showing the current domain
 > }}}
 > It is no SVG anymore as far as I can see.

 Fixed.

 > 2) I agree that this bug fixes #13074 as well. If you have that fix in
 the same commit (which is fine for me) please give a hint in the commit
 message as well. This makes it a lot easier for people doing the release
 to get the changelog right (they can then just look for bug numbers with
 |git log|)

 Good idea. I've added a mention of #13704.

 > I tested a while the ar version and it behaves weird. (See attachment)
 Not sure if that is something we can/should fix, though. I guess there is
 an RTL/LTR mixup causing this due to yet untranslated strings?

 Yes, it's partly due to untranslated strings. The circuit diagram should
 turn around if everything is translated. You're right that the parentheses
 are misbehaving, though, so I've added a fix for those.


 Here is the new patch:
 https://github.com/arthuredelstein/torbutton/commit/ac63db8d95fce5f743c04a8c4f5cca7b852504e8

 Here is the corrected circuit display in English, Arabic, and Farsi:

 [[Image(circuitDIsplay_english.png)]] [[Image(circuitDisplay_arabic.png)]]
 [[Image(circuitDisplay_farsi.png)]]

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15086#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online