[tbb-bugs] #11236 [Tor Browser]: Omnibox in non-english TBBs has DuckDuckGo as default search engine

[Tor Bug Tracker & Wiki]

#11236: Omnibox in non-english TBBs has DuckDuckGo as default search engine
-------------------------+-------------------------------------------------
     Reporter:  gk       |      Owner:  tbb-team
         Type:  defect   |     Status:  needs_review
     Priority:  normal   |  Milestone:
    Component:  Tor      |    Version:
  Browser                |   Keywords:  tbb-testcase, tbb-firefox-patch,
   Resolution:           |  TorBrowserTeam201501R
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------
Changes (by gk):

 * status:  new => needs_review
 * keywords:  tbb-testcase, tbb-firefox-patch => tbb-testcase, tbb-firefox-
     patch, TorBrowserTeam201501R


Comment:

 Okay, this was a huge PITA but here come some patches. The idea behind
 them is to a) fix the problem and b) avoid translators shooting themselves
 in the foot by translating the search box search engine names. In order to
 do so moved setting the default search engines out of Torbutton and put
 that into our default Tor Browser preference file using
 `browser.search.order.extra.`. This works as these prefs are consulted
 first when constructing the search engine order: see
 `_buildSortedEngineList()` https://mxr.mozilla.org/mozilla-
 esr31/source/toolkit/components/search/nsSearchService.js#3671. The funny
 thing is, the default engine we want has to be set with
 `browser.search.order.extra.3`, the second one with
 `browser.search.order.extra.1` and the third one, you guess it, with
 `browser.search.order.extra.2`. This problem does, even more surprisingly,
 not happen if one just wants to set 2 search engines on the top of the
 list. This seems to be a Mozilla bug to me which I still need to file.

 The code to review is: bug_11236_v3 in my public tor-browser repo,
 bug_11236_v2 in my public torbutton repo and bug_11236 in my public tor-
 browser-bunlde-testsuite repo.

 The test currently only checks whether we have Startpage as default search
 engine set. Testing for DuckDuckGo and Google being on second/third
 position was harder than I though and I deferred that to a ticket I have
 yet to file. Should be okay for the bug at hand I think.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11236#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online