[tbb-bugs] #14851 [Tor Browser]: NoScript update caused permissions pref update

[Tor Bug Tracker & Wiki]

#14851: NoScript update caused permissions pref update
-----------------------------+--------------------------------------------
     Reporter:  mikeperry    |      Owner:  tbb-team
         Type:  defect       |     Status:  closed
     Priority:  normal       |  Milestone:
    Component:  Tor Browser  |    Version:
   Resolution:  fixed        |   Keywords:  TorBrowserTeam201502, tbb-pref
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------------------------
Changes (by mikeperry):

 * keywords:  TorBrowserTeam201502, tbb-disk-leak, tbb-pref =>
     TorBrowserTeam201502, tbb-pref


Comment:

 Actually, after testing, it seems that even with this pref set, allowed
 sites weren't hitting the disk. This is because we only expose
 "Temporarily allow all this site" in our NoScript menu, which used the
 temporary store regardless of this pref value.

 So, as a result this was only a disk leak for people who actually altered
 their NoScript menu to expose menu options that we normally don't (such as
 "Allow [...]"). Changing NoScript settings like that is unsupported. There
 are tons of ways to get it to do bad things that way, which I have no
 interest in trying to clean up after...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14851#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online