[tbb-bugs] #9442 [Tor Browser]: Add New Circuit button to TorButton

[Tor Bug Tracker & Wiki]

#9442: Add New Circuit button to TorButton
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  tbb-team
  cypherpunks            |     Status:  needs_review
         Type:           |  Milestone:
  enhancement            |    Version:
     Priority:  normal   |   Keywords:  tbb-newnym, tbb-easy, tbb-
    Component:  Tor      |  usability, extdev-interview, tbb-torbutton,
  Browser                |  TorBrowserTeam201502R, MikePerry201502
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by arthuredelstein):

 Replying to [comment:20 mikeperry]:
 > Ok, I implemented this in commit
 6ba3a3d11bc1fb6a3415aa7363062bec1d6ac964 of mikeperry/1.8-next in my
 torbutton remote:
 https://gitweb.torproject.org/mikeperry/torbutton.git/commit/?h=1.8-next&id=d67b6db8409eea440aace24a1be297dcd7bcce4a
 >
 > However, there appears to be a bug in our SOCKS username+password patch
 that is causing Tor Browser to always send "0" as the password, even
 though the SOCKS password is clearly being updated in the nsIProxyInfo.
 Arthur - can you have a look?

 This turned out to be a bad bug where the proxyInfo was being cached for a
 given URL, even though the username/password had changed. Obviously that's
 very bad for circuit isolation. I've posted a patch here:
 https://github.com/arthuredelstein/tor-
 browser/commit/981c39e35f07cfa6a4bf934ba463f78d4ab796ce

 Another bug shows up once my fix is applied: #14866.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9442#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online